[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[leafnode-list] More embedded NULLs in posts




Spammers are really start to annoy me for other reasons now.

Consider this following extract from strace -s 4096 telnet newsserver nntp:
recv(4, ".....\r\nend\r\n\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\r\n\r\n.\r\n", 7819, 0) = 1468

This causes the following code from fetchnews.c to be invoked:
        if ( !l ) {     /* article didn't terminate with a .: timeout */
            unlink( c );
            return server;
        }

Which then causes the rest of the group to be skipped.  A rather annoying
result, I must say.

When the getaline() stuff came up, someone mentioned a potential missed
patch for the 1.9 series that I pretty much duplicated.  Would this fall
into the same situation?  I'm beginning to think my patch wasn't
sufficient.

mrc
-- 
       Mike Castle       Life is like a clock:  You can work constantly
  dalgoda@xxxxxxxxxxxxx  and be right all the time, or not work at all
www.netcom.com/~dalgoda/ and be right at least twice a day.  -- mrc
    We are all of us living in the shadow of Manhattan.  -- Watchmen

-- 
leafnode-list@xxxxxxxxxxxxxxxxxxxxxxxxxxxx -- mailing list for leafnode
To unsubscribe, send mail with "unsubscribe" in the subject to the list