[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [leafnode-list] Still fighting with delaybody mode



* Matthias Andree <ma@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> [010129 21:50]:
 
> > --- fetchnews.c.orig    Tue Jan 23 23:49:28 2001
> > +++ fetchnews.c Sun Jan 28 20:16:29 2001
> ..
> > @@ -323,13 +324,16 @@
> >      }
> >  
> >      while ( ( l = getaline( f ) ) != NULL ) {
> > +        mid = strdup( l );              /* Save msgid */
> >         putaline( "ARTICLE %s", l );
> >         if ( !getarticle( NULL ) )
> > -           appendtolist( &failed, &ptr, l );
> > +           appendtolist( &failed, &ptr, mid );
> > +        free( mid );
> 
> This is exactly the sort of patch which is counter productive and
> destabilizes leafnode. Dispose of it.
 
Sorry, but you've missed the point. This is exactly the sort of patch 
which prevents fetchnews from writing back junk if the requested 
article could not be retrieved.

Concerning your reflections on error checking, I'd urge you to
have a look at how strdup() is used throughout the whole code. 
I've used it in a consistent way on my part. 

Best regards - Juergen.

-- 
Light travels faster than sound.  That's why some people
appear bright until you hear them speak.


-- 
leafnode-list@xxxxxxxxxxxxxxxxxxxxxxxxxxxx -- mailing list for leafnode
To unsubscribe, send mail with "unsubscribe" in the subject to the list