[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[leafnode-list] [ANNOUNCE] leafnode-2.0b7.tar.gz



It appears that fetchnews from leafnode-2.0b6 dumps core under certain
conditions, especially if it is run the first time on a freshly installed
system. Gunnar Ritter mailed me a patch which seems to fix the problem.
Therefore I release now leafnode-2.0b7. You can find it at the usual
place:
	ftp://wpxx02.toxi.uni-wuerzburg.de/~pub/leafnode-2.0b7.tar.gz

For people who prefer patches, here is a patch (it's fairly short):

---cut here---
--- leafnode-2.0b6/activutil.c	Tue Jan  2 13:40:01 2001
+++ leafnode-2.0b/activutil.c	Wed Jan  3 09:53:51 2001
@@ -133,7 +133,7 @@
     size_t mid;
     long result;
 
-    if ( low > high )
+    if ( low > high || (int)high < 0 )
 	return -1 ;
     mid = (high-low)/2+low;
     result = strcasecmp( name, active[mid].name );
--- leafnode-2.0b6/ChangeLog	Tue Jan  2 13:40:01 2001
+++ leafnode-2.0b/ChangeLog	Wed Jan  3 10:06:16 2001
@@ -1,3 +1,35 @@
+History of 2.0b7 -- changes since 2.0b6:
+
+fetchnews:
+=========
+
+030101: main(): variable "newsgroup" made static. Reported by Stefan
+	Fleiter <stefan.fleiter@xxxxxx>, patch by Matthias Andree
+	<ma@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>.
+
+libutil:
+=======
+
+030101: configutil: format error in readconfig() fixed. Reported by
+	Stefan Fleiter <stefan.fleiter@xxxxxx>.
+030101: activutil: helpfindgroup() dumped core on several architectures (with
+	(int)high = -1 and low = 0). Bug report and patch by Gunnar Ritter 
+	<g-r@xxxxxxxxxx>.
+
+Miscellaneous:
+=============
+
+030101: Makefile.in: if fetchnews had not been run at least once, "make
+	uninstall" barfed. Reported by Martin Kissel <martinkissel@xxxxxxxxxx>.
+030101: Makefile.in: if no /etc/leafnode/config was already installed,
+	"make install" barfed. Reported by Martin Kissel
+	<martinkissel@xxxxxxxxxx>.
+030101: configure.in: socklen_t test failed on OpenBSD because <sys/types.h>
+	was not included before <sys/socket.h>. Patch by Bruno Rohee
+	<rohee@xxxxxxxxxxx>.
+
+----------------------------------------------------------------------------
+
 History of 2.0b6 -- changes since 2.0b5:
 
 General comments:
--- leafnode-2.0b6/configure.in	Tue Jan  2 13:40:01 2001
+++ leafnode-2.0b/configure.in	Wed Jan  3 09:37:41 2001
@@ -5,7 +5,7 @@
 AC_CONFIG_HEADER(config.h)
 
 dnl Version information
-VERSION="2.0b6"
+VERSION="2.0b7"
 AC_SUBST(VERSION)
 
 dnl Checks for programs.
@@ -59,6 +59,7 @@
 dnl Check whether socklen_t is defined in /usr/include/sys/socket.h
 AC_MSG_CHECKING(for socklen_t)
 AC_CACHE_VAL(cf_cv_socklen_t, AC_TRY_COMPILE([
+#include <sys/types.h>
 #include <sys/socket.h>],[
     socklen_t fodder;
     return fodder;],
--- leafnode-2.0b6/configutil.c	Tue Jan  2 13:40:01 2001
+++ leafnode-2.0b/configutil.c	Wed Jan  3 10:03:45 2001
@@ -361,7 +361,7 @@
         if ( getrlimit( RLIMIT_CORE, &corelimit ) < 0 )
 	    syslog( LOG_DEBUG, "Getting core file size failed: %m" );
 	else
-	    syslog( LOG_DEBUG, "Core file size: %d", corelimit.rlim_cur );
+	    syslog( LOG_DEBUG, "Core file size: %ld", corelimit.rlim_cur );
     }
 
     free( param );
--- leafnode-2.0b6/fetchnews.c	Tue Jan  2 13:40:01 2001
+++ leafnode-2.0b/fetchnews.c	Wed Jan  3 10:05:06 2001
@@ -1521,7 +1521,7 @@
     volatile time_t lastrun;
     char * conffile;
     static char * msgid = NULL;
-    char * newsgroup = NULL;
+    static char * newsgroup = NULL;
 
     verbose = 0;
     postonly = 0;
--- leafnode-2.0b6/Makefile.in	Tue Jan  2 13:40:01 2001
+++ leafnode-2.0b/Makefile.in	Wed Jan  3 10:03:07 2001
@@ -196,8 +196,9 @@
 	cp $(srcdir)/config.example $(INSTALLROOT)$(LIBDIR)
 	-chown news:news $(INSTALLROOT)$(LIBDIR)/config.example
 	-chmod 600 $(INSTALLROOT)$(LIBDIR)/config.example
-	-chown -f news:news $(INSTALLROOT)$(LIBDIR)/config
-	-chmod -f 600 $(INSTALLROOT)$(LIBDIR)/config
+	if test -f $(INSTALLROOT)$(LIBDIR)/config ; then \
+	  chown -f news:news $(INSTALLROOT)$(LIBDIR)/config ; \
+	  chmod -f 600 $(INSTALLROOT)$(LIBDIR)/config ; fi
 	chmod 2755 $(INSTALLROOT)$(SPOOLDIR)
 	@echo Edit /etc/inetd.conf to start $(INSTALLROOT)$(BINDIR)/leafnode and restart inetd.
 	@echo Also read the instructions on updating in the README file.
@@ -224,7 +225,7 @@
 	-rm -r $(LIBDIR)
 	-rm -r $(SPOOLDIR)/leaf.node
 	-rm -r $(SPOOLDIR)/interesting.groups
-	-rm -r $(SPOOLDIR)/message.id/*
+	-rm -rf $(SPOOLDIR)/message.id/*
 	-rmdir $(SPOOLDIR)/out.going
 	@echo Edit /etc/inetd.conf to remove $(BINDIR)/leafnode and restart inetd
---cut here---

For people who use local groups, please note also that leafnode now
expects the "local.groups" file in /etc/leafnode or whatever you
set LIBDIR to, not in /var/spool/news/leaf.node .

My apologies,

--Cornelius.

--  
/* Cornelius Krasel, U Wuerzburg, Dept. of Pharmacology, Versbacher Str. 9 */
/* D-97078 Wuerzburg, Germany   email: krasel@xxxxxxxxxxxxxxxxxxxxxxxxxxxx */
/* "Science is the game we play with God to find out what His rules are."  */

-- 
leafnode-list@xxxxxxxxxxxxxxxxxxxxxxxxxxxx -- mailing list for leafnode
To unsubscribe, send mail with "unsubscribe" in the subject to the list