[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [leafnode-list] Whoah. Bugs galore in hashing.

krasel@xxxxxxxxxxxxxxxxxxxxxxxxxxxx (Cornelius Krasel) writes:

> > a) name is char[], if that's signed or unsigned is implementation-dependent
> > b) r is unsigned int
> > c) name is cast to (signed) int.
> > d) the hashing function is embedded. Wrong. Belongs into a separate function.
> In other words, the function does not contain a single bug, although
> it is certainly not an example of good programming.

It's complex and no-one can understand it at one glance. That's reason
enough to get rid of it.

Matthias Andree

leafnode-list@xxxxxxxxxxxxxxxxxxxxxxxxxxxx -- mailing list for leafnode
To unsubscribe, send mail with "unsubscribe" in the subject to the list