[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [leafnode-list] Multi-level Local Newsgroups Name Bugs

Matthias Andree <ma@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> writes:

> Stefan Wiens <s.wi@xxxxxxx> writes:
>> "Bulgrien, Dennis" <Dennis.Bulgrien@xxxxxxxxxxxxxxxxxx> writes:
>> > Given Local Newsgroups:
>> >   x
>> >   x.y
>> I'd avoid that, although Leafnode should cope with it.
> Why should it? There's no such thing in real life, if x is to be split,
> it is renamed x.misc and the new group x.y added.

There are historical cases. See alt.sex, alt.drugs, alt.rock-n-roll.

>> >     Jun 25 11:33:07 arendi leafnode[8252]: wrote
>> > /var/spool/news/x.y/.overview
>                   -----
> Something's really broken there.

I overlooked that. How could it happen?

>> +    char *arg = strdup(oarg);
>>      if ( !strcasecmp(arg, "extensions") ) {
> Wow. Crash here in OOM condition, the same bug you just reported against
> my getxoverline() :-) You need to check arg against the 0 pointer.

I should have stressed that I did introduce that "bug" by careless use
of a leafnode library function.
The original nntpd.c doesn't suffer from it.

>    g->count = g->last - g->first + 1;
>    if (g->count < 0) g->count = 0;

g->first and g->last are unsigned.
One of my upstream servers advances the low water mark beyond the high
water mark when expiring the last article, what is IMHO consistent.


leafnode-list@xxxxxxxxxxxxxxxxxxxxxxxxxxxx -- mailing list for leafnode
To unsubscribe, send mail with "unsubscribe" in the subject to the list