[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [leafnode-list] Problem with texpire



Stefan Wiens <s.wi@xxxxxxx> writes:

> Matthias Andree <ma@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> writes:
> 
> > Stefan Wiens <s.wi@xxxxxxx> writes:
> >
> >> To find broken overview lines:
> >> find /var/spool/news -name .overview | \
> >>         xargs awk -v FS="\t" '{if(NF>9)print FILENAME" "$0}'
> >
> > None here[TM].
> 
> Not really surprising.
> 
> Instead, your WIP-20010605-1 getxoverline() will get SIGSEGV in
> tab2spc() should strdup() fail.

Yup, I haven't yet reworked all places to do proper error checking. I
have a critstrdup call for these places, but I am delaying the next
snapshot release until I have fixed at least one of the long-standing
major issues, otherwise, it'd be pointless.

> Documented issue, see texpire(8). Groups not in groupinfo are
> currently ignored.

Ok. Bad Thing[tm].

> I'd be "not amused" should texpire ever clean up my site-local
> subdirectories under /var/spool/news. That would be too surprising,
> even if documented.

What other chance would there be. What site-local subdirectories belong
below /var/spool/news? /var/spool/news belongs to the news server,
nobody else. local groups are listed, so I don't see the point. My
leafnode only has its own directories there. You could of course
generate diffs when fetching a new groupinfo from the upstreams, vs. the
old one, and put all groups on a "has vanished, can be expired" list --
but that's added complexity for border cases. Rather make the spooldir
belong to leafnode and nothing but leafnode and have it clean up
everything it does not know. You don't expect to be able to store
site-local data in /var/spool/mqueue, /var/spool/postfix/active or
/var/qmail/queue either. We can rename the default spool dir
/var/spool/leafnode, of course. In the long run, we'd better close the
spool dir anyways. Supporting local-spool and efficient NNTP access at
the same time is not a good idea.

-- 
Matthias Andree

-- 
leafnode-list@xxxxxxxxxxxxxxxxxxxxxxxxxxxx -- mailing list for leafnode
To unsubscribe, send mail with "unsubscribe" in the subject to the list