[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [leafnode-list] lockfile_exists disaster, analysis of 1.9.19 and



-----BEGIN PGP SIGNED MESSAGE-----

Matthias Andree <ma@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> writes:

> Well, there is one more problem with respect to locking: the new locking
> schemes (regardless whether Cornelius' suggestion or my function) CANNOT
> HAND OVER THE LOCK ACROSS fork().

What happens is as soon as the parent exited, the lock will be
considered stale.

> Clear text: the lock is lost when fetchnews forks, the child would have
> to acquire the lock again. I'm currently working on a solution.

Well, it's easier than I thought at first. 2.0b8 doesn't need the locks,
it just updates the .xoverinfos, 1.9.19 does, but that can be alleviated
by moving the groupinfo update to the parent, the child then no longer
needs the lock.

I have two patches that hopefully fix the locking issue. Please test.

Fix for 1.9.19:

http://mandree.home.pages.de/leafnode/fix-1.9.19-locking.patch
http://mandree.home.pages.de/leafnode/fix-1.9.19-locking.patch.sig

Fix for 2.0b8: (note this slightly changes fetchnews because the new
lockfile.c does not support "silent == 0" verbose mode)

http://mandree.home.pages.de/leafnode/beta/fix-2.0b8-locking.patch
http://mandree.home.pages.de/leafnode/beta/fix-2.0b8-locking.patch.sig

The .sig files are GPG signatures.

- -- 
Matthias Andree

-----BEGIN PGP SIGNATURE-----
Version: 2.6.3i
Charset: noconv
Comment: Processed by Mailcrypt 3.5.5, an Emacs/PGP interface

iQCVAwUBOyntmidEoB0mv1ypAQHgmgQAmQ0glxIkQl0nXsD3IJZNsy2kvOcy/q6B
UxZJwuK+9GN7Kxu9cKix6Ri6zymxnvs2MBZiDNMRlM4zc7s9yvrEs0ccih75f4ke
f4l2AnLT27uzpXjePULuGjN9vbsqEQOOs52zyhMo/H8MzPIFyKjI2Mpk1rc0RLrU
szx4h43GxAg=
=2ixH
-----END PGP SIGNATURE-----

-- 
leafnode-list@xxxxxxxxxxxxxxxxxxxxxxxxxxxx -- mailing list for leafnode
To unsubscribe, send mail with "unsubscribe" in the subject to the list