[leafnode-list] texpire in 2.0b8_ma7.5pre with miscutil.c patch

[Michael Mauch <michael.mauch@xxxxxx>]

Hi,

before applying the miscutil.c patch, texpire took more than half an
hour for heavy disk activity and logging such lines:

Oct 14 22:00:01 elmicha texpire[8096]: config: debugmode is 1
Oct 14 22:00:01 elmicha texpire[8096]: reading /var/spool/news/leaf.node/groupinfo and /etc/leafnode/local.groups
Oct 14 22:00:02 elmicha texpire[8096]: ngmatch(pattern = "de.comp.os.unix.linux.misc", str = "24hoursupport.helpdesk") == 0
Oct 14 22:00:02 elmicha texpire[8096]: ngmatch(pattern = "de.comp.os.unix.linux.misc", str = "3com.totalservice") == 0
[...]
Oct 14 22:35:21 elmicha texpire[8096]: ngmatch(pattern = "de.comp.os.unix.linux.misc", str = "to.ids-scheer") == 0
Oct 14 22:35:21 elmicha texpire[8096]: ngmatch(pattern = "de.comp.os.unix.linux.misc", str = "to.ids-scheer.de") == 0

I guess the miscutil.c patch fixed that problem, but now I get a
segfault directly at the first group:

Program received signal SIGSEGV, Segmentation fault.
lookup_expire (group=0x8067c90 "24hoursupport.helpdesk") at texpire.c:579

The relevant function:

static time_t lookup_expire(char *group)
{
    struct expire_entry *a;
    
    for (a = expire_base ; a ; a = a->next) {
    	if (ngmatch(a->group, group) == 0)
    	    return a->xtime;
    	a = a->next;
    }
    return default_expire;
}

Isn't this one "a = a->next" too much?

Regards...
		Michael

-- 
leafnode-list@xxxxxxxxxxxxxxxxxxxxxxxxxxxx -- mailing list for leafnode
To unsubscribe, send mail with "unsubscribe" in the subject to the list