Re: [leafnode-list] ma9rc1 fetchnews not fetching

[Matthias Andree <ma@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>]

Mike Castle schrieb am Dienstag, den 08. Januar 2002:

> Ok... more issues:
> 
> thune:/var/spool/news/interesting.groups# fetchnews -vvv
> fetchnews: version 2.0b8_ma9rc1; verbosity level is 3; debugging level is 0
> reading /var/spool/news/leaf.node/groupinfo and /etc/leafnode/local.groups
> found 0 articles in in.coming.
> expiring interesting.groups
> corp.supernews.com: connecting to port nntp
>   trying address 209.249.90.101 port 119...
>   connected: address 209.249.90.101 port 119.
> corp.supernews.com: connected (200), banner: "200 Supernews NNRP server
> ready - http://www.supernews.com (posting ok)"
> corp.supernews.com: TCP send buffer size is 16384
> corp.supernews.com: checking for new newsgroups
> corp.supernews.com: found 0 new newsgroups
> 0Û0Ûtwar  not found in groupinfo file
> xx0Û not found in groupinfo file

I'm an idiot, that's what I get for hurrying a release candidate out
without testing. Will be fixed in rc2.

In the meanwhile, here's the quick fix -- leafnode would read the
interesting.groups and then free them right away, before using them. For
some reason, this would not cause immediate segfaults (it would have
with efence), so it went unnoticed.

Removing the second "free(k)" line is important, the other is just
saving some compilation time (and relying on libc resource tracking).

Index: miscutil.c
===================================================================
RCS file: /home/emma/mycvsroot/leafnode/miscutil.c,v
retrieving revision 1.18
diff -u -r1.18 miscutil.c
--- miscutil.c	2002/01/08 17:42:18	1.18
+++ miscutil.c	2002/01/09 00:46:25
@@ -342,11 +342,8 @@
 	if (!rbsearch(k, rb)) {
 	    ln_log(LNLOG_SERR, LNLOG_CTOP, "out of memory in "
 		   "isinteresting, cannot build rbtree");
-	    mastr_delete(t);
-	    free(k);
 	    exit(EXIT_FAILURE);
 	}
-	free(k);
     }
     (void)closedir(d);
     mastr_delete(t);

-- 
leafnode-list@xxxxxxxxxxxxxxxxxxxxxxxxxxxx -- mailing list for leafnode
To unsubscribe, send mail with "unsubscribe" in the subject to the list