[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [leafnode-list] fix SEGV in nntpd.c

Jonathan Larmour <jlarmour@xxxxxxxxxx> writes:

> Jonathan Larmour wrote:
>> This is again against 1.9.20.rel. If fetchnews runs, it causes any existing
>> running clients to SEGV because the active file is stamped, causing it 
> Actually this patch evidently wasn't quite right, so here it is fixed -
> xovergroup is only meant to be set to group when the xover data in memory
> matches the group. So just NULLify it instead, so that getxover() will be
> run again.
> It does seem a bit odd to reread the entire xover data again though.

Well, running concurrent processes will always increase the overhead,
and if we're reading from a current xover file, we're not wasting too
much time, but presumedly, we're reading from the buffer cache, so it
should not be too expensive.

> Perhaps someone should consider a different approach? Anyway, this patch
> should do the trick now:
> 2002-04-01  Jonathan Larmour  <jlarmour@xxxxxxxxxx>
>         * nntpd.c (rereadactive): Preserve group between rereadings.

Applied, thanks.

Matthias Andree

leafnode-list@xxxxxxxxxxxxxxxxxxxxxxxxxxxx -- mailing list for leafnode
To unsubscribe, send mail with "unsubscribe" in the subject to the list