[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [leafnode-list] fix SEGV in nntpd.c



* Jonathan Larmour wrote:
> Ralf Wildenhues wrote:
> > 
> > For 'group' (which is local static to main_loop()) the only place I can
> > see a change to storage reachable by variable 'active' being triggered
> > without 'group' being changed is dolist("active"), that is "LIST
> > ACTIVE".  valgrind confirms this bug. 'group' should probably be copied
> > and findgroup()ed again, xovergroup set to group afterwards (in case it
> > was before).
> 
> You have to make sure that the xovergroup matches group only when the xover
> data is loaded, otherwise they may be out of sync with each other after a
> LIST ACTIVE is done.

Suppose it would be safe to just set it to NULL in any case, so the
overview would be reread.

HAND
Ralf

-- 
leafnode-list@xxxxxxxxxxxxxxxxxxxxxxxxxxxx -- mailing list for leafnode
To unsubscribe, send mail with "unsubscribe" in the subject to the list