[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[leafnode-list] WARNING: leafnode 1.9.23 NO-GO with slrn. 1.9.24 due shortly.
Hello,
because of slrn braindeadness, a bug in leafnode 1.9.23.rc3 and 1.9.23
is triggered that leads to immediate crash (disconnect).
I am grateful to all those of you who did not test 1.9.23.rc3 although
it was announced here and on freshmeat... NOT!
Please feel guilty if you waited for 1.9.23 but did not try 1.9.23.rc3.
1.9.24 is to be released once I have confirmation by the original bug
reporter that the problem is gone with Ralf's patch. I do trust Ralf,
the patch looks good, so this is just formal action.
If anyone else wants to test, here's a patch against 1.9.23.rel, this
shall be released as 1.9.24.rel today. Please do test and send feedback:
works/does not work, which newsreader you tested it on, operating system
and release (version), CPU (architecture).
diff -Nur leafnode-1.9.23.rel/ChangeLog leafnode-1.9.24.rc1/ChangeLog
--- leafnode-1.9.23.rel/ChangeLog Mon Jul 8 20:24:55 2002
+++ leafnode-1.9.24.rc1/ChangeLog Tue Jul 9 14:23:56 2002
@@ -1,4 +1,29 @@
+2002-07-09 Matthias Andree <matthias.andree@xxxxxx>
+
+ === release 1.9.24.rc1 ===
+ * nntpd.c: remove all ihave traces.
+ * nntpd.c: more nogroup() merge.
+ * configure.ac: bump version
+
+2002-07-09 Ralf Wildenhues <ralf.wildenhues@xxxxxx>
+
+ * applyfilter.c: Typo in log comment.
+
+2002-07-09 Matthias Andree <matthias.andree@xxxxxx>
+
+ * nntpd.c: use nogroup() in doxhdr().
+
+2002-07-09 Ralf Wildenhues <ralf.wildenhues@xxxxxx>
+
+ * nntpd.c: Fix XOVER segfault before GROUP.
+
2002-07-08 Matthias Andree <matthias.andree@xxxxxx>
+
+ * configure.ac: Bump version to 1.9.24.pre1 for formal reasons.
+ * Makefile.am: Let the lsm targets depend on genlsm.sh to ensure
+ that a current version of genlsm.sh is used to build the .lsm file.
+ * genlsm.sh.in: Revamp .lsm
+ * NEWS: Add release date.
=== RELEASE 1.9.23.rel ===
* configure.ac: Bump version to 1.9.23.rel.
diff -Nur leafnode-1.9.23.rel/Makefile.am leafnode-1.9.24.rc1/Makefile.am
--- leafnode-1.9.23.rel/Makefile.am Fri Jul 5 16:40:22 2002
+++ leafnode-1.9.24.rc1/Makefile.am Tue Jul 9 01:19:54 2002
@@ -61,8 +61,11 @@
filterutil.o: filterutil.c $(PCREDEP)
-lsm @PACKAGE@-@VERSION@.lsm: dist
+@PACKAGE@-@VERSION@.lsm: dist ./genlsm.sh
$(SHELL) ./genlsm.sh >@PACKAGE@-@VERSION@.lsm
+
+.PHONY: lsm
+lsm: @PACKAGE@-@VERSION@.lsm
libpcre.a: pcre/.libs/libpcre.a
cp pcre/.libs/libpcre.a $@
diff -Nur leafnode-1.9.23.rel/Makefile.in leafnode-1.9.24.rc1/Makefile.in
--- leafnode-1.9.23.rel/Makefile.in Mon Jul 8 20:25:10 2002
+++ leafnode-1.9.24.rc1/Makefile.in Tue Jul 9 14:14:12 2002
@@ -996,8 +996,11 @@
filterutil.o: filterutil.c $(PCREDEP)
-lsm @PACKAGE@-@VERSION@.lsm: dist
+@PACKAGE@-@VERSION@.lsm: dist ./genlsm.sh
$(SHELL) ./genlsm.sh >@PACKAGE@-@VERSION@.lsm
+
+.PHONY: lsm
+lsm: @PACKAGE@-@VERSION@.lsm
libpcre.a: pcre/.libs/libpcre.a
cp pcre/.libs/libpcre.a $@
diff -Nur leafnode-1.9.23.rel/NEWS leafnode-1.9.24.rc1/NEWS
--- leafnode-1.9.23.rel/NEWS Mon Jul 8 20:28:42 2002
+++ leafnode-1.9.24.rc1/NEWS Tue Jul 9 14:22:38 2002
@@ -1,4 +1,21 @@
================================================================================
+* 1.9.24, 2002-07-08
+
+### INCOMPATIBLE CHANGES:
+- See all "incompatible changes" sections below.
+
+### GENERAL
+
+- there will be no more prereleases or release candidates. people don't
+ test them.
+
+### nntpd
+
+- no longer crashes (SIGSEGV) when a client sends "XOVER" before
+ "GROUP". slrn is so dumb to try this, so you cannot use leafnode
+ 1.9.23 with slrn.
+
+================================================================================
* 1.9.23, 2002-07-08
### INCOMPATIBLE CHANGES:
diff -Nur leafnode-1.9.23.rel/applyfilter.c leafnode-1.9.24.rc1/applyfilter.c
--- leafnode-1.9.23.rel/applyfilter.c Fri Jul 5 13:05:09 2002
+++ leafnode-1.9.24.rc1/applyfilter.c Tue Jul 9 14:12:59 2002
@@ -249,7 +249,7 @@
} else {
if (f) {
ln_log(LNLOG_SERR, LNLOG_CARTICLE,
- "could not stat %s or not a reglar file\n",
+ "could not stat %s or not a regular file\n",
de->d_name);
(void)fclose(f);
} else {
diff -Nur leafnode-1.9.23.rel/configure leafnode-1.9.24.rc1/configure
--- leafnode-1.9.23.rel/configure Mon Jul 8 20:25:15 2002
+++ leafnode-1.9.24.rc1/configure Tue Jul 9 14:14:14 2002
@@ -1453,7 +1453,7 @@
# Define the identity of the package.
PACKAGE=leafnode
- VERSION=1.9.23.rel
+ VERSION=1.9.24.rc1
cat >>confdefs.h <<_ACEOF
diff -Nur leafnode-1.9.23.rel/configure.ac leafnode-1.9.24.rc1/configure.ac
--- leafnode-1.9.23.rel/configure.ac Fri Jul 5 21:35:22 2002
+++ leafnode-1.9.24.rc1/configure.ac Tue Jul 9 14:12:53 2002
@@ -5,7 +5,7 @@
AC_INIT
AC_PREREQ(2.53)
AC_CONFIG_SRCDIR([leafnode.h])
-AM_INIT_AUTOMAKE(leafnode,1.9.23.rel)
+AM_INIT_AUTOMAKE(leafnode,1.9.24.rc1)
AM_CONFIG_HEADER(config.h)
AM_MAINTAINER_MODE
diff -Nur leafnode-1.9.23.rel/genlsm.sh.in leafnode-1.9.24.rc1/genlsm.sh.in
--- leafnode-1.9.23.rel/genlsm.sh.in Sun Jun 23 02:17:56 2002
+++ leafnode-1.9.24.rc1/genlsm.sh.in Tue Jul 9 01:32:16 2002
@@ -5,13 +5,16 @@
Begin4
Title: @PACKAGE@
Version: @VERSION@
-Entered-date: `date +%Y-%m-%d`
+Entered-date: `date -u +%Y-%m-%d`
Description: News server package for small sites.
Features include: easy to install and maintain; only read
groups are downloaded; separate download of headers and
- bodies possible; filtering of headers for regular expressions
-Keywords: newsserver, offline, small sites, netnews
-Author: krasel@xxxxxxxxxxxxxxxxxxxxxxxxxxxx (Cornelius Krasel)
+ bodies possible; filtering of headers for regular expressions.
+Keywords: newsserver, offline, small sites, netnews, usenet, NNTP
+Author: matthias.andree@xxxxxx (Matthias Andree)
+ ralf.wildenhues@xxxxxx (Ralf Wildenhues)
+ krasel@xxxxxxxxxxxxxxxxxxxxxxxxxxxx (Dr. Cornelius Krasel)
+ agulbra@xxxxxxxx (Arnt Gulbrandsen)
Maintained-by: matthias.andree@xxxxxx (Matthias Andree)
Primary-site: ftp://wpxx02.toxi.uni-wuerzburg.de/pub/
`ls -sk @PACKAGE@-@VERSION@.tar.gz | \
@@ -19,7 +22,8 @@
Alternate-site: ftp://metalab.unc.edu/pub/Linux/system/news/transport/
`ls -sk @PACKAGE@-@VERSION@.tar.gz | \
@AWK@ '{ printf "%dkB", $1 }'` @PACKAGE@-@VERSION@.tar.gz
-Platforms: Linux, NetBSD, FreeBSD, OpenBSD, IRIX, Solaris, other Unixes?
-Copying-policy: MIT, parts GPL
+Platforms: Linux, NetBSD, FreeBSD, OpenBSD, IRIX, Solaris, HP-UX, ...
+ with PCRE installed (see http://www.pcre.org/)
+Copying-policy: MIT, parts GPL or LGPL
End
EOF
diff -Nur leafnode-1.9.23.rel/leafnode.spec leafnode-1.9.24.rc1/leafnode.spec
--- leafnode-1.9.23.rel/leafnode.spec Mon Jul 8 20:25:23 2002
+++ leafnode-1.9.24.rc1/leafnode.spec Tue Jul 9 14:17:17 2002
@@ -1,7 +1,7 @@
# DO NOT EDIT!
# leafnode.spec. Generated from leafnode.spec.in by configure.
-Version: 1.9.23.rel
+Version: 1.9.24.rc1
Summary: Leafnode - a leafsite NNTP server (Version %version)
Summary(de): Leafnode - ein offline-Newsserver (Version %version)
Name: leafnode
diff -Nur leafnode-1.9.23.rel/nntpd.c leafnode-1.9.24.rc1/nntpd.c
--- leafnode-1.9.23.rel/nntpd.c Fri Jul 5 20:46:30 2002
+++ leafnode-1.9.24.rc1/nntpd.c Tue Jul 9 14:13:55 2002
@@ -89,6 +89,7 @@
void doxover(char *);
void dolistgroup(const char *);
static void markinterest(const char *);
+static void nogroup(void);
static struct newsgroup *group; /* current group, initially none */
static struct newsgroup *xovergroup = NULL;
@@ -201,10 +202,6 @@
doarticle(arg, 0);
} else if (!strcasecmp(cmd, "help")) {
dohelp();
- } else if (!strcasecmp(cmd, "ihave")) {
- if (debugmode)
- syslog(LOG_DEBUG, ">500 IHAVE is for big news servers");
- printf("500 IHAVE is for big news servers\r\n");
} else if (!strcasecmp(cmd, "last")) {
domove(-1);
} else if (!strcasecmp(cmd, "next")) {
@@ -460,9 +457,7 @@
f = fopenart(arg);
if (!f) {
if (arg && *arg != '<' && !group) {
- printf("412 No newsgroup selected\r\n");
- if (debugmode)
- syslog(LOG_DEBUG, ">412 No newsgroup selected");
+ nogroup();
} else if (strlen(arg)) {
printf("430 No such article: %s\r\n", arg);
if (debugmode)
@@ -728,7 +723,6 @@
printf(" group newsgroup\r\n");
printf(" head [MessageID|Number]\r\n");
printf(" help\r\n");
- printf(" ihave\r\n");
printf(" last\r\n");
/* printf(" list [active|newsgroups|distributions|schema] [group_pattern]\r\n"); */
printf(" list [active|newsgroups] [group_pattern]\r\n");
@@ -786,9 +780,7 @@
syslog(LOG_DEBUG, ">420 There is no current article");
}
} else {
- if (debugmode)
- syslog(LOG_DEBUG, ">412 No newsgroup selected");
- printf("412 No newsgroup selected\r\n");
+ nogroup();
}
}
@@ -1316,9 +1308,7 @@
}
if (!group) {
- if (debugmode)
- syslog(LOG_DEBUG, ">412 Use the GROUP command first");
- printf("412 Use the GROUP command first\r\n");
+ nogroup();
free(buf);
return;
}
@@ -1493,7 +1483,10 @@
{
unsigned long a, b, art;
- if (!group) nogroup();
+ if (!group) {
+ nogroup();
+ return;
+ }
markinterest(group->name);
a = group->first;
@@ -1581,9 +1574,7 @@
} else if (group) {
g = group;
} else {
- printf("412 No group specified\r\n");
- if (debugmode)
- syslog(LOG_DEBUG, ">412 No group specified");
+ nogroup();
return;
}
--
Matthias Andree
--
leafnode-list@xxxxxxxxxxxxxxxxxxxxxxxxxxxx -- mailing list for leafnode
To unsubscribe, send mail with "unsubscribe" in the subject to the list