[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[leafnode-list] snapshot-20020904a fixes newly introduced -0902a bug with crosspostings



-----BEGIN PGP SIGNED MESSAGE-----

Hello,

Joerg Dietrich found out that my new store.c patch to write the .overview
data is broken, it will only work correctly for postings to one group,
but write bogus overview data for cross-postings.

The patch below fixes this, I have also uploaded
leafnode-2.0-snapshot-20020904a.tar.bz2 to
http://mandree.home.pages.de/leafnode/beta/

Should you have used fetchnews from snapshot-20020902a, your .overview
data is likely bogus. To have the .overview files fixed, just delete
them all, like this:

find /var/spool/news -name .overview -exec rm '{}' ';'

leafnode will recreate the .overview files as needed.

If you want them all recreated in one go, you can run texpire.

Note to Ralf and Joerg: This is not the full patch as in CVS, but one
reduced to the hunk with the actual fix.

- --- store.c~	2002/09/02 00:24:39
+++ store.c	2002/09/03 23:25:04
@@ -478,12 +478,13 @@
 	    if (!tt) tt = p + strlen(p);
 	    if (*tt == ' ') *tt++ = '\0';
 	    else *tt = '\0';
- -	    /* now p has the file name in the group */
+	    /* now p has the number the article has in the current group */
 
 	    if (chdirgroup(q, FALSE)) {
 		int fdo;
 
- -		mastr_vcat(xowrite, nb, strchr(ov, '\t'), "\n", NULL);
+		mastr_clear(xowrite);
+		mastr_vcat(xowrite, p, strchr(ov, '\t'), "\n", NULL);
 		fdo = open(".overview", O_WRONLY|O_APPEND|O_CREAT,
 			(mode_t)0660);
 		if (fdo >= 0) {

- -- 
Matthias Andree
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (GNU/Linux)

iQCVAwUBPXVJdCdEoB0mv1ypAQETcgQAjdWp6Po7D/A6m0rI089n2RipVTDd6/tD
iZPLMMfIAan9ehZonXvq9gCU8++oK0KSOenbo0sWXR3yiJD1PiihGJenu9JmYfBg
BP1DJF5yHYe8zjSnaoKdKyHPELN45i1LzSj/wjG1BTxayPfvKXe2MSFhvVYzpVEB
B8e2QIfT3kQ=
=zVvl
-----END PGP SIGNATURE-----

-- 
leafnode-list@xxxxxxxxxxxxxxxxxxxxxxxxxxxx -- mailing list for leafnode
To unsubscribe, send mail with "unsubscribe" in the subject to the list