[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[leafnode-list] Re: leafnode-2.0.0.alpha20021108a



On Sat, Nov 09 2002, Matthias Andree wrote:

> This should fix the 4294967295 issue that Reiner Steib has
> observed. 

It almost fixed it. I can access those groups now. But I lost (in the
sense that I cannot see it im my newsreader) one article (number `0')
in those groups. Example:

/var/spool/news/gmane/network/leafnode/announce$ /bin/ls -lA
total 8
-rw-r--r--    1 news     news            0 Oct 23 13:21 .last.posting
-rw-rw-r--    1 news     news          235 Nov  9 17:30 .overview
-rw-r--r--    2 news     news         6429 Oct 21 15:45 0

For me, this is not important. When I subscribe to a new group now,
it's okay: New articles start with number 2 (number 1 is dummy
article, I guess).

> Just update, it should figure the right low/high marks the next time
> texpire, applyfilter or fetchnews is run and save them temporarily;
> it will temporarily fix these when leafnode itself is run.

I ran "fetchnews -vvv -n", after installing the new version.

> IF AND ONLY IF you have group_pcre filtering in place, [...]

I don't.

> The mailto.c compile failure has also been fixed.

Before I forget: I couldn't compile alpha20021108a (neither on SuSE
7.1 nor on 7.2):

,----
| gcc -DHAVE_CONFIG_H -I. -I. -I.     -g -O2  -Wall -W \
|   -Wstrict-prototypes -Wmissing-prototypes -Wshadow -Wbad-function-cast \
|   -Wcast-qual -Wcast-align -Wwrite-strings -Waggregate-return \
|   -Wmissing-declarations -Wnested-externs -ggdb -fno-common -c `test -f \
|   'fetchnews.c' || echo './'`fetchnews.c \
| fetchnews.c: In function `nntpactive':
| fetchnews.c:1357: parse error before `unsigned'
| fetchnews.c: In function `remove_watermark':
| fetchnews.c:1596: warning: cast discards qualifiers from pointer target type
| make[2]: *** [fetchnews.o] Error 1
`----

It's this relevant part of the code:

	    if (is_interesting(l)
		    && (forceact || !(active && findgroup(l, active, -1)))
		    && chdirgroup(l, FALSE)) {
		first = ULONG_MAX;
		last = 0;
		unsigned long count;
		if (getwatermarks(&first, &last, &count) || 0 == count) {
		    /* trouble or empty group */
		    first = last = 0;
		}
	    }

- Shouldn't the declaration "unsigned long count;" be at the top of
  if-clause, before "first = ULONG_MAX;"? I moved it up, then I got:

- "declaration of `count' shadows previous local". There's already a
  declaration of `count' in line 1247. I removed the second
  declaration, but I'm not sure if this is what you intended.

--8<---------------cut here---------------start------------->8---
--- fetchnews.c.orig	Sat Nov  9 00:14:47 2002
+++ fetchnews.c	Sat Nov  9 17:57:17 2002
@@ -1354,7 +1354,6 @@
 		    && chdirgroup(l, FALSE)) {
 		first = ULONG_MAX;
 		last = 0;
-		unsigned long count;
 		if (getwatermarks(&first, &last, &count) || 0 == count) {
 		    /* trouble or empty group */
 		    first = last = 0;
--8<---------------cut here---------------end--------------->8---

> Reiner, could you check if your problem is fixed now and report back?

[x] done.

Thank you for the quick reply and the fix, Matthias!

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo--- PGP key available via WWW   http://rsteib.home.pages.de/

-- 
leafnode-list@xxxxxxxxxxxxxxxxxxxxxxxxxxxx -- mailing list for leafnode
To unsubscribe, send mail with "unsubscribe" in the subject to the list