[leafnode-list] maxage == 0

[Jonathan Larmour <jifl@xxxxxxxxxx>]

<x-flowed>
leafnode seems to whinge overly about what I believe to be a correct use 
of maxage == 0.

I think the attached patch (against 1.9.27) makes sense... localmaxage 
should be left at maxage, and only changed if the global or group expiry 
is greater. I don't see why maxage being set to 0 should affect these 
limits as the whole point of setting maxage to 0 is to prevent any 
checking *at all*.

For that matter I'm unclear what setting clamp_maxage = 0 is meant to 
achieve anyway. The only time clamp_maxage is tested is when the value of 
0 tells you via syslog that your configuration is broken and should be fixed.

Jifl

--- fetchnews.c.orig	Sat Aug 31 10:52:51 2002
+++ fetchnews.c	Thu Nov 14 18:22:21 2002
@@ -17,7 +17,7 @@
 Copyright of the modifications 2000 - 2002.
 Modified by Ralf Wildenhues <ralf.wildenhues@xxxxxx>.
 Copyright of the modifications 2002.
-Modified by Jonathan Larmour <jlarmour@xxxxxxxxxx>.
+Modified by Jonathan Larmour <jifl@xxxxxxxxxx>.
 Copyright of the modifications 2002.
 See file COPYING for restrictions on the use of this software.
@@ -605,12 +605,12 @@
     (void)chdirgroup(g->name, TRUE);
     if ((exp = lookup_expiredays(g->name)) > 0) {
-	if ((localmaxage == 0) || (localmaxage > exp)) {
+	if (localmaxage > exp) {
 	    maxagelimit = exp;
 	    limitfrom = "groupexpire";
 	}
     } else {
-	if (localmaxage == 0 || localmaxage > expiredays) {
+	if (localmaxage > expiredays) {
 	    maxagelimit = expiredays;
 	    limitfrom = "global expire";
 	}
--
--[ "You can complain because roses have thorns, or you ]--
--[  can rejoice because thorns have roses." -Lincoln   ]-- Opinions==mine
--
leafnode-list@xxxxxxxxxxxxxxxxxxxxxxxxxxxx -- mailing list for leafnode
To unsubscribe, send mail with "unsubscribe" in the subject to the list
</x-flowed>