[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

leafnode-2.0.0.alpha20030209a available (was: [leafnode-list]



Werner Partner <kairos@xxxxxxxxxxx> writes:

> The two last messages could refer to two trials of posting

I see two bugs. 1. the missing error message to the client, 2. the
message.id/123/ directory is not created.

Both bugs are fixed in leafnode-2.0.0.alpha20030209a, download location
is in the signature. There's also a patch against
leafnode-2.0.0.alpha20030203a:

diff -Nur /tmp/leafnode-2.0.0.alpha20030203a/activutil.c /tmp/leafnode-2.0.0.alpha20030209a/activutil.c
--- /tmp/leafnode-2.0.0.alpha20030203a/activutil.c	2003-01-28 13:46:07.000000000 +0100
+++ /tmp/leafnode-2.0.0.alpha20030209a/activutil.c	2003-02-10 00:25:20.000000000 +0100
@@ -389,8 +389,7 @@
 	ln_log_sys(LNLOG_SERR, LNLOG_CTOP, "unable to open %s: %m",
 		mastr_str(s));
 	mastr_delete(s);
-	active = (struct newsgroup *)critmalloc(sizeof(struct newsgroup),
-		"readactive");
+	active = NULL;
 	activesize = 0;
 	return;
     }
diff -Nur /tmp/leafnode-2.0.0.alpha20030203a/config.c /tmp/leafnode-2.0.0.alpha20030209a/config.c
--- /tmp/leafnode-2.0.0.alpha20030203a/config.c	2003-02-03 01:15:26.000000000 +0100
+++ /tmp/leafnode-2.0.0.alpha20030209a/config.c	2003-02-10 00:48:57.000000000 +0100
@@ -5,6 +5,6 @@
 const char *spooldir = "/var/spool/leafnode";
 const char *sysconfdir = "/etc/leafnode";
 const char *lockfile = "/var/lock/news/fetchnews.lck";
-const char *version = "2.0.0.alpha20030203a";
+const char *version = "2.0.0.alpha20030209a";
 const char *DEFAULTMTA = "/usr/sbin/sendmail";
 const char *RUNAS_USER = "news";
diff -Nur /tmp/leafnode-2.0.0.alpha20030203a/configure /tmp/leafnode-2.0.0.alpha20030209a/configure
--- /tmp/leafnode-2.0.0.alpha20030203a/configure	2003-02-03 01:15:17.000000000 +0100
+++ /tmp/leafnode-2.0.0.alpha20030209a/configure	2003-02-10 00:48:48.000000000 +0100
@@ -1,5 +1,5 @@
 #! /bin/sh
-# From configure.ac Revision: 1.47 .
+# From configure.ac Revision: 1.48 .
 # Guess values for system-dependent variables and create Makefiles.
 # Generated by GNU Autoconf 2.57.
 #
@@ -1538,7 +1538,7 @@
 
 # Define the identity of the package.
  PACKAGE=leafnode
- VERSION=2.0.0.alpha20030203a
+ VERSION=2.0.0.alpha20030209a
 
 
 cat >>confdefs.h <<_ACEOF
diff -Nur /tmp/leafnode-2.0.0.alpha20030203a/configure.ac /tmp/leafnode-2.0.0.alpha20030209a/configure.ac
--- /tmp/leafnode-2.0.0.alpha20030203a/configure.ac	2003-02-03 01:14:57.000000000 +0100
+++ /tmp/leafnode-2.0.0.alpha20030209a/configure.ac	2003-02-10 00:48:30.000000000 +0100
@@ -4,9 +4,9 @@
 dnl Process this file with autoconf to produce a configure script.
 AC_INIT
 AC_CONFIG_SRCDIR([leafnode.h])
-AM_INIT_AUTOMAKE([leafnode],[2.0.0.alpha20030203a])
+AM_INIT_AUTOMAKE([leafnode],[2.0.0.alpha20030209a])
 AC_PREREQ(2.57)
-AC_REVISION($Revision: 1.47 $)
+AC_REVISION($Revision: 1.48 $)
 AC_CONFIG_SRCDIR(leafnode.h)
 AC_CONFIG_HEADERS([config.h])
 dnl AM_MAINTAINER_MODE
diff -Nur /tmp/leafnode-2.0.0.alpha20030203a/leafnode.spec /tmp/leafnode-2.0.0.alpha20030209a/leafnode.spec
--- /tmp/leafnode-2.0.0.alpha20030203a/leafnode.spec	2003-02-03 01:15:27.000000000 +0100
+++ /tmp/leafnode-2.0.0.alpha20030209a/leafnode.spec	2003-02-10 00:48:57.000000000 +0100
@@ -1,7 +1,7 @@
 # DO NOT EDIT!
 # leafnode.spec.  Generated from leafnode.spec.in by configure.
 
-Version: 2.0.0.alpha20030203a
+Version: 2.0.0.alpha20030209a
 Summary: Leafnode - a leafsite NNTP server (version %version)
 Summary(de): Leafnode - ein offline-Newsserver (Version %version)
 Name: leafnode
diff -Nur /tmp/leafnode-2.0.0.alpha20030203a/midutil.c /tmp/leafnode-2.0.0.alpha20030209a/midutil.c
--- /tmp/leafnode-2.0.0.alpha20030203a/midutil.c	2003-01-28 01:28:01.000000000 +0100
+++ /tmp/leafnode-2.0.0.alpha20030209a/midutil.c	2003-02-10 00:39:33.000000000 +0100
@@ -1,5 +1,6 @@
 #include "critmem.h"
 #include "ln_log.h"
+#include "ln_dir.h"
 #include "leafnode.h"
 #include "mastring.h"
 #include "msgid.h"
@@ -79,7 +80,9 @@
 msgid_allocate(const char *file /** file to link into message.id */,
 	const char *mid /** Non-NULL Message-ID to allocate */)
 {
-    const char *m = lookup(mid);
+    char *m = lookup(mid);
+    if (mkdir_parent(m, 0700))
+	return 0;
     if (sync_link(file, m) == 0) {
 	return 0;
     }
diff -Nur /tmp/leafnode-2.0.0.alpha20030203a/nntpd.c /tmp/leafnode-2.0.0.alpha20030209a/nntpd.c
--- /tmp/leafnode-2.0.0.alpha20030203a/nntpd.c	2003-01-28 01:03:38.000000000 +0100
+++ /tmp/leafnode-2.0.0.alpha20030209a/nntpd.c	2003-02-10 00:39:33.000000000 +0100
@@ -1524,7 +1524,7 @@
 	/* check if we can obtain the MID or if the article is duplicate */
 	switch(msgid_allocate(inname, mid)) {
 	    case 1:
-		nntpprintf("441 435 Duplicate, article not posted");
+		nntpprintf("441 435 Duplicate, article not posted.");
 		log_unlink(inname, 0);
 		goto cleanup;
 		break;
@@ -1532,6 +1532,7 @@
 		/* OK */
 		break;
 	    default:
+		nntpprintf("441 Server error: cannot allocate Message-ID.");
 		ln_log(LNLOG_SERR, LNLOG_CTOP, "cannot link %s to %s: %m",
 			inname, lookup(mid));
 		log_unlink(inname, 0);


-- 
Matthias Andree
leafnode-1 download: http://sourceforge.net/projects/leafnode/
leafnode-1 docs/new: http://mandree.home.pages.de/leafnode/
leafnode-2 homepage: http://mandree.home.pages.de/leafnode/beta/

-- 
leafnode-list@xxxxxxxxxxxxxxxxxxxxxxxxxxxx -- mailing list for leafnode
To unsubscribe, send mail with "unsubscribe" in the subject to the list