[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [leafnode-list] placeholder articles after running applyfilter (was: artutil.c:58:



Reiner Steib schrieb am 2003-10-03:

> On Thu, Oct 02 2003, Reiner Steib wrote:
> 
> > when running "cd interesting.groups; for i in *;do echo
> > $i;applyfilter $i;done".
> 
> BTW, I got lots of "Leafnode placeholder" articles in Gnus.  Those
> groups are not new, but they didn't contain any articles at that time.

Please try this patch. If the problem persists, please show an NNTP
trace (might be a Gnus bug, its XOVER handling doesn't seem too robust).

One more question: are you running Gnus with suppression of duplicate
articles enabled? I do, so I may not see the "lots of" -- all those
place holders have a constant (though group-specific) Message-ID.

The last hunk of the patch is the most important one, without it, you
cannot request a pseudo article with XOVER n, for instance. Makes me
wonder where the others come from though...

Index: nntpd.c
===================================================================
RCS file: /var/CVS/leafnode-2/nntpd.c,v
retrieving revision 1.121
retrieving revision 1.122
diff -u -r1.121 -r1.122
--- nntpd.c	29 Jul 2003 21:34:46 -0000	1.121
+++ nntpd.c	9 Oct 2003 00:50:54 -0000	1.122
@@ -407,10 +407,8 @@
     /* when the client cannot subscribe, no group will be pseudo */
     if (!allowsubscribe()) return FALSE;
 
-#if 0
     /* interesting is never pseudo */
     if (is_interesting(group)) return FALSE;
-#endif
 
     /* make sure that is_localgroup is FALSE here: */
     if (!chdirgroup(group, FALSE)) return TRUE;
@@ -833,12 +831,11 @@
 	opengroup(g);
 
 	if (is_pseudogroup(g->name))
-	    count = 1;
+	    nntpprintf("211 %lu %lu %lu %s group selected",
+		    1, g->first, g->first, g->name);
 	else
-	    count = g->count;
-
-	nntpprintf("211 %lu %lu %lu %s group selected",
-		   count, g->first, g->last, g->name);
+	    nntpprintf("211 %lu %lu %lu %s group selected",
+		    g->count, g->first, g->last, g->name);
 	*artno = g->first;
 
 	fflush(stdout);
@@ -2072,7 +2069,7 @@
 	}
     } else {
 	/* _is_ pseudogroup */
-	if (!b) b = a;
+	if (!(i & RANGE_HAVETO)) b = a;
 	if (arg && (b < group->first || a > b || a > group->last+1)) {
 	    nntpprintf("420 No articles in specified range.");
 	    return;

-- 
leafnode-list@xxxxxxxxxxxxxxxxxxxxxxxxxxxx -- mailing list for leafnode
To unsubscribe, send mail with "unsubscribe" in the subject to the list