[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [leafnode-list] Groups Not Being Removed



On Tue, 16 Dec 2003, Jeff Grossman wrote:

> I am running the 1129a build of 2.0.  I continually see the following groups
> in my texpire output even though there are no messages left.  Aren't the
> groups supposed to be automatically removed?
> 
> public.mozdev.communicator: 0 articles deleted, 0 kept
> public.mozdev.chimera: 0 articles deleted, 0 kept
> tin.dev: 0 articles deleted, 0 kept
> tin.users: 0 articles deleted, 0 kept
> tin.bugs: 0 articles deleted, 0 kept
> tin.announce: 0 articles deleted, 0 kept

Looking at my current CVS code which hasn't changed in the past three
weeks in that area, texpire will keep the groups (even with empty
directories) when they are marked dormant (/etc/leafnode/dormant.groups
contains tin.dev) or interesting
(/var/spool/news/intersting.groups/tin.dev exists).

Can you confirm if that is the case?

Does the following patch clarify the situation when you run texpire -vvv
again? (works against your version and the later 1203a snapshot)

Index: texpire.c
===================================================================
RCS file: /var/CVS/leafnode-2/texpire.c,v
retrieving revision 1.41
diff -u -r1.41 texpire.c
--- texpire.c	3 Nov 2003 20:05:23 -0000	1.41
+++ texpire.c	16 Dec 2003 22:49:57 -0000
@@ -134,7 +134,7 @@
 	if (errno != ENOENT)
 	    ln_log(LNLOG_SERR, LNLOG_CGROUP, "unlink %s/%s: %m", logprefix, file);
     } else {
-	ln_log(LNLOG_SDEBUG, LNLOG_CGROUP, "unlinked %s/%s", logprefix, file);
+	ln_log(LNLOG_SINFO, LNLOG_CGROUP, "unlinked %s/%s", logprefix, file);
     }
 }
 
@@ -870,8 +870,11 @@
 		    return;
 		}
 	    }
+	} else {
+	    ln_log(LNLOG_SINFO, LNLOG_CGROUP, "not removing %s because it is interesting or dormant.", n);
 	}
     }
+
     /* Once we're done and there's something left we have to update the
      * .overview file. Otherwise unsubscribed groups will never be
      * deleted.

-- 
leafnode-list@xxxxxxxxxxxxxxxxxxxxxxxxxxxx -- mailing list for leafnode
To unsubscribe, send mail with "unsubscribe" in the subject to the list