[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[leafnode-list] anyone seeing 1.9.50 "groupinfo not present or too small"?



Hi,

A bug report was filed on sourceforge, reporting a fetchnews bug, where
fetchnews is falsely reporting "groupinfo not present or too small" when
the file is well above 2 MB.

Out of interest: Is anyone seeing this in 1.9.50? The bug is present and
there is a fix (patch below) but I cannot seem to trigger it. If you can
trigger it, please state whether it's a fresh install or an update, what
OS you're on and if you're using the filterfile option.

Thanks.

Index: fetchnews.c
===================================================================
RCS file: /var/CVS/leafnode-1/fetchnews.c,v
retrieving revision 1.141
diff -u -r1.141 fetchnews.c
--- fetchnews.c	10 Feb 2004 19:12:27 -0000	1.141
+++ fetchnews.c	19 Feb 2004 20:57:47 -0000
@@ -2216,18 +2216,19 @@
 
     /* legacy code by Mark Brown, moved here out of nntpactive */
     {
+	int staterror;
 	struct stat st;
 	char s[SIZE_s+1];
 
 	xsnprintf(s, SIZE_s, "%s/leaf.node/groupinfo", spooldir);
-	if (stat(s, &st) && errno != ENOENT) {
+	if ((staterror = stat(s, &st)) && errno != ENOENT) {
 	    /* this should happen only when the problem occurs after
 	     * readactive() above, but needs to be checked nonetheless */
 	    ln_log(LNLOG_SERR, LNLOG_CTOP, "Cannot open %s: %m", s);
 	    unlink(lockfile);
 	    exit(EXIT_FAILURE);
 	}
-	if (errno == ENOENT || st.st_size < 7) {
+	if (staterror || st.st_size < 7) {
 	    ln_log(LNLOG_SNOTICE, LNLOG_CTOP, "Groupinfo file %s not present or too small, forcing active fetch.", s);
 	    forceactive = 1;
 	}

-- 
Matthias Andree

Encrypt your mail: my GnuPG key ID is 0x052E7D95
-- 
_______________________________________________
leafnode-list mailing list
leafnode-list@xxxxxxxxxxxxxxxxxxxxxxxxxxxx
http://www.dt.e-technik.uni-dortmund.de/mailman/listinfo/leafnode-list
http://leafnode.sourceforge.net/