[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [leafnode-list] inaccurate response to GROUP command

Brian Sammon <leafnode-list@xxxxxxxxxxxxxxxxxxxxx> writes:

>> > Okay, but it doesn't do anything if the group is empty.  I subscribe to som 
>> > groups that are currently empty and I'd like it to keep them marked 
>> > interesting as well.
>> That should work, the patch implements refreshing the subscription if list
>> active is requested with a single newsgroups. As per your description,
>> this should help knews.
> Yeah, but if the group is a "pseudogroup", it doesn't.  And apparently, an 
> empty group qualifies as a pseudogroup.

Unless it is in interesting.groups.

The problem seems to be that list active doesn't handle pseudo groups
properly and returns

215 blah
group.name 1 2 y

Oops. Does this patch help (leave the previous one in)?

diff -u -r1.115 nntpd.c
--- nntpd.c	26 Jul 2004 09:04:18 -0000	1.115
+++ nntpd.c	26 Jul 2004 09:04:30 -0000
@@ -740,7 +740,10 @@
     switch(what) {
 	case 0:
-	    printf("%s %lu %lu y\r\n", g->name, g->last, g->first);
+	    if (is_pseudogroup(g))
+		printf("%s %lu %lu y\r\n", g->name, g->first, g->first);
+	    else
+		printf("%s %lu %lu y\r\n", g->name, g->last, g->first);
 	case 1:
 	    printf("%s\t%s\r\n", g->name, g->desc ? g->desc : "-x-");

Matthias Andree

Encrypted mail welcome: my GnuPG key ID is 0x052E7D95 (PGP/MIME preferred)
leafnode-list mailing list