Re: [leafnode-list] leafnode-2.0.0.alpha20040916a snapshot available

[Matthias Andree <matthias.andree@xxxxxx>]

Robert Clark schrieb am 2004-09-17:

> Matthias Andree wrote:
> > 20040916a: Changes since 20040915a:
> > + Change: leafnode, the NNTP daemon, will no longer update overview
> >   information, in an attempt to fix Yvon Thoraval's slowness observed on
> >   MacOS X. If the groups appear inaccessible, running either fetchnews
> >   or texpire should fix this.
> 
> I installed this update yesterday, but had to back it out and go back to
> 2.0.0.alpha20040915a as I could not get any client to see new articles.
> Running fetchnews and texpire manually did not seem to help.

Jack Raats schrieb am 2004-09-18:

> This new version gives me the following error
> 
> 420 No articles in specified range.
> 
> I did a texpire -r, but it didn't seem to work!

OK, there was a problem with setting internal global variables that kept
the article numbers, which caused XOVER (among others) to fail in the
ways you describe.

This patch on top of 20040916a fixes the problem:

Index: xoverutil.c
===================================================================
RCS file: /var/CVS/leafnode-2/xoverutil.c,v
retrieving revision 1.50
diff -u -r1.50 xoverutil.c
--- xoverutil.c	16 Sep 2004 11:07:17 -0000	1.50
+++ xoverutil.c	20 Sep 2004 10:34:11 -0000
@@ -365,6 +365,9 @@
     long i;
 
     freexover();
+    xfirst = ULONG_MAX; /* will be lowered accordingly */
+    xlast = 0;		/* will be raised accordingly */
+    xcount = 0;
 
     fd = open(".overview", O_RDONLY);
     if (fd < 0) {
@@ -416,9 +419,6 @@
 	/* find article range on disk, store into xcount */
 	/* FIXME: don't choke on numeric subgroups */
 	/* FIXME: get this under the same roof as nntpd's dogroup */
-	xcount = 0;
-	xlast = 0;
-	xfirst = ULONG_MAX;
 	for (t = dl; *t; t++) {
 	    if (!get_ulong(*t, &art))
 		abort();		/* FIXME: must not happen */
@@ -428,8 +428,6 @@
 	    if (art > xlast)
 		xlast = art;
 	}
-    } else {
-	xcount = 0;
     }
 
     /* parse .overview file */
@@ -458,6 +456,8 @@
 		xoverinfo[current].exists = 0;
 		xoverinfo[current].artno = art;
 		current++;
+		if (art < xfirst) xfirst = art;
+		if (art > xlast) xlast = art;
 	    }
 	}
 	p = q;

-- 
Matthias Andree

Encrypted mail welcome: my GnuPG key ID is 0x052E7D95 (PGP/MIME preferred)
-- 
_______________________________________________
leafnode-list mailing list
leafnode-list@xxxxxxxxxxxxxxxxxxxxxxxxxxxx
http://www.dt.e-technik.uni-dortmund.de/mailman/listinfo/leafnode-list
http://leafnode.sourceforge.net/