Re: [leafnode-list] Still fighting with delaybody mode

[Matthias Andree <ma@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>]

Juergen Salk <juergen.salk@xxxxxx> writes:

> Actually it will be the error messages of the upstream server, that are 
> written back to the interesting.groups files. I've tried 
> to fix that with the following patch, which seems to work for me. (Although
> this does not remove any messages from the list, of course.)
> 
> --- fetchnews.c.orig    Tue Jan 23 23:49:28 2001
> +++ fetchnews.c Sun Jan 28 20:16:29 2001
..
> @@ -323,13 +324,16 @@
>      }
>  
>      while ( ( l = getaline( f ) ) != NULL ) {
> +        mid = strdup( l );              /* Save msgid */
>         putaline( "ARTICLE %s", l );
>         if ( !getarticle( NULL ) )
> -           appendtolist( &failed, &ptr, l );
> +           appendtolist( &failed, &ptr, mid );
> +        free( mid );

What's the point of this? Putaline has no access to the static buffer
inside getaline, and appendtolist does not call getaline; so this patch
merely generates overhead (malloc, strcpy, free) without changing the
functionality; plus it has no error checking (on strdup, mid may be
0). This is exactly the sort of patch which is counter productive and
destabilizes leafnode. Dispose of it.

-- 
Matthias Andree

-- 
leafnode-list@xxxxxxxxxxxxxxxxxxxxxxxxxxxx -- mailing list for leafnode
To unsubscribe, send mail with "unsubscribe" in the subject to the list